View Issue Details

IDProjectCategoryView StatusLast Update
0000437HeurekaTPGpublic2021-06-22 09:55
ReporterPeder Assigned ToLinus  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionopen 
Product Version2.17.5 
Target Version2.17.6Fixed in Version2.17.6 
Summary0000437: Error when handling enforce first thinning and StemDensityThinningGuide is used
DescriptionRow 1297, class TreatmentProgramGenerator:
  enforcedFirstThinning = noOfThinnings == 0 && enforcedFirstThinning && tUnit.Before.BasalAreaExclOverstorey >= _planVisTreatmentControlTable.MinPropOfBasalAreaBefore * thinGuide.MinValueBeforeThinning;

When thinning guide is set StemDensityThinningGuide, then thinGuide.MinValueBeforeThinning refers to basal area thinning guide and is has value 0. This means the enforced thinning will approved if even stems number is very low (1 tree is enough).

Steps To ReproduceImport attached stand register, or create a spruce stand with height 12, age 22 and SIS = 30
Run PlanWise with Thinning Guide set to StemDensityThinningGuide.

Expected result: thinGuide.MinValueBeforeThinning should be > 0
Also, condition should use predicate of thinning guide, in this case stem density and not basal area.

Also note line 2451-2456: Is thinning enforced before "enforcement" criteria above are checked?
TagsNo tags attached.
Attached Files
Bugg437.csv (707 bytes)   
AreaLevel2;AreaLevel3;StandId;Layer;Register;Date;CoordEast;CoordNorth;ProdArea;MeanAge;G;N;Dgv;Dg;V;MeanHeight;MaturityClass;SKSManagementClass;BlueTargetClass;SiteIndexSpecies;SiteIndex;SI_Management;SIH;VegetationType;BottomLayer;SoilMoistureCode;SoilWaterCode;SoilTextureCode;Peat;Ditch;Latitude;Altitude;SoilBearingCapacity;Surface;Slope;EvenAged;LastClearcutYear;LastThinningYear;LastFertilizationYear;LastRegenerationYear;RegenerationMethod;RegenerationSpecies;Breeded;TerrainRoadSlope;TerrainTransportDistance;PropPine;PropSpruce
;;66E9i9790;1;;2020-09-15 00:00;489079;6699701;107.2772206;20;2.6;246;12.8;11.6;16;11.4;;PG;;G;26;30;;;;;;;;;60.12630498;0;;;;;2013;;;2015;;;;;;0.1666667;0.8333333
Bugg437.csv (707 bytes)   
ProductPlanWise

Activities

Linus

2021-06-22 09:55

administrator   ~0000420

StemDensityThinningGuide now checks stem density to determine if thinning is applicable. Enforced thinnings now check this criteria before being added to a treatment specification, and before being performed.

Issue History

Date Modified Username Field Change
2021-06-07 10:46 Peder New Issue
2021-06-07 10:49 Peder Steps to Reproduce Updated
2021-06-07 10:51 Peder File Added: Bugg437.csv
2021-06-22 09:51 Linus Changeset attached => heureka trunk r20896
2021-06-22 09:55 Linus Assigned To => Linus
2021-06-22 09:55 Linus Status new => resolved
2021-06-22 09:55 Linus Product Version => 2.17.5
2021-06-22 09:55 Linus Fixed in Version => 2.17.6
2021-06-22 09:55 Linus Target Version => 2.17.6
2021-06-22 09:55 Linus Note Added: 0000420